You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just realized the changes made to fix the problem on macOS might cause problems with servers running both Samba and Netatalk. The vfs_fruit module use the exact same code to verify AppleDouble file headers. It would obviously fail a check in ad_entry_check_size() if the length of a PRIVDEV field is 4 vs. 8. As far as I know, OpenBSD and DragonflyBSD are supported Samba platforms. DragonflyBSD likely can't use vfs_fruit due to the lack of extended attribute support (is this still the case? Netatalk disables support) so likely wouldn't be a problem. Pinging @slowfranklin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdmark
force-pushed
the
rdmark-bsd-loosen-ad
branch
from
Applying the fix for macOS in #1829